[
https://issues.apache.org/jira/browse/ZOOKEEPER-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633352#comment-15633352
]
ASF GitHub Bot commented on ZOOKEEPER-2624:
-------------------------------------------
Github user fpj commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/97#discussion_r86386008
--- Diff: build.xml ---
@@ -1622,6 +1623,26 @@
xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
</exec>
</target>
+ <target name="qa-test-pullrequest"
depends="findbugs.check,forrest.check">
+ <exec executable="bash" failonerror="true">
+ <arg value="${test_pullrequest_sh}"/>
+ <arg value="QABUILD"/>
+ <arg value="${scratch.dir}"/>
+ <arg value="${ps.cmd}"/>
+ <arg value="${wget.cmd}"/>
+ <arg value="${jiracli.cmd}"/>
+ <arg value="${git.cmd}"/>
+ <arg value="${grep.cmd}"/>
+ <arg value="${patch.cmd}"/>
+ <arg value="${findbugs.home}"/>
+ <arg value="${forrest.home}"/>
+ <arg value="${basedir}"/>
+ <arg value="${jira.passwd}"/>
+ <arg value="${java5.home}"/>
+ <arg value="${curl.cmd}"/>
--- End diff --
yes, it was intentionally left out. the `defect` number is the jira number.
in the jira qa, that is being set by the trigger of the jira patch. if you look
further down in the script, you'll see that I'm setting the `defect` variable
by extracting the number from the PR title. I expect the PR title to contain
the jira title `ZOOKEEPER-XXXX: Bla bla bla`.
> Add test script for pull requests
> ---------------------------------
>
> Key: ZOOKEEPER-2624
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2624
> Project: ZooKeeper
> Issue Type: Improvement
> Components: scripts
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
>
> We need a script similar to {{test-patch.sh}} to handle QA builds for pull
> requests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
