Agreed, we should have a ticket to look into them, I'm not sure why we are getting those warnings. We got it even for ZK-2624, which should give us no warnings.
I asked about findbugs on the builds list, but no one was able to tell me whether findbugs has been updated or not. -Flavio > On 04 Nov 2016, at 17:24, Michael Han <h...@cloudera.com> wrote: > > I just noticed that in recent pre-commit builds, there are 19 - 20 'new' > find bug warnings appear to at least three different JIRA issues: > > ZOOKEEPER-1621 > https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3513/artifact/build/test/findbugs/newPatchFindbugsWarnings.html > > ZOOKEEPER-1525 > https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3515/artifact/build/test/findbugs/newPatchFindbugsWarnings.html > > ZOOKEEPER-2014 > https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3516/artifact/build/test/findbugs/newPatchFindbugsWarnings.html > > After triaging the warnings, I think most if not all the warnings are not > caused by these patches as the code leads to the warnings is not touched by > these patch. Maybe findbug tool is updated to a new version so it caught > more issues? I guess we should try to fix these warnings in a separate jira > if they are legitimate. > > On Thu, Nov 3, 2016 at 2:43 PM, Flavio Junqueira <f...@apache.org> wrote: > >> The last 3 builds failed that way and nothing has changed as far as I >> know. If it persists, we should open an infra ticket. >> >> -Flavio >> >>> On 03 Nov 2016, at 19:26, Jordan Zimmerman <jor...@jordanzimmerman.com> >> wrote: >>> >>> The pre-build for ZOOKEEPER-1525 is failing with this error. Any ideas? >>> >>> BUILD FAILED >>> /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1580: >> 'findbugs.home' is not defined. Please pass -Dfindbugs.home=<base of >> Findbugs installation> to Ant on the command-line. >>> >>> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3511/console >> >> > > > -- > Cheers > Michael.
