[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641217#comment-15641217
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2014:
-------------------------------------------

Github user breed commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/96#discussion_r86678939
  
    --- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
    @@ -1108,6 +1109,42 @@ server.3=zoo3:2888:3888</programlisting>
                   </para>
                 </listitem>
               </varlistentry>
    +
    +          <varlistentry>
    +            <term>reconfigEnabled</term>
    +
    +            <listitem>
    +              <para>(No Java system property)</para>
    +
    +              <para><emphasis role="bold">New in 3.5.3:</emphasis>
    +                This controls the enabling or disabling of
    +                <ulink url="zookeeperReconfig.html">
    +                  Dynamic Reconfiguration</ulink> feature. When the feature
    +                is enabled, users can perform reconfigure operations 
through
    +                the ZooKeeper client API or through ZooKeeper command line 
tools
    +                assuming users are authorized to perform such operations.
    +                When the feature is disabled, no user, including the super 
user,
    +                can perform a reconfiguration. Any attempt to reconfigure 
will return an error.
    +                <emphasis role="bold">"reconfigEnabled"</emphasis> option 
can be set as
    +                <emphasis role="bold">"reconfigEnabled=false"</emphasis> or
    +                <emphasis role="bold">"reconfigEnabled=true"</emphasis>
    +                to a server's config file, or using QuorumPeerConfig's
    +                setReconfigEnabled method. The default value is false.
    +
    +                If present, the value should be consistent across every 
server in
    +                the entire ensemble. Setting the value as true on some 
servers and false
    +                on other servers will cause inconsistent behavior depends 
on which server
    --- End diff --
    
    depends -> depending


> Only admin should be allowed to reconfig a cluster
> --------------------------------------------------
>
>                 Key: ZOOKEEPER-2014
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2014
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.5.0
>            Reporter: Raul Gutierrez Segales
>            Assignee: Michael Han
>            Priority: Blocker
>             Fix For: 3.5.3
>
>         Attachments: ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch
>
>
> ZOOKEEPER-107 introduces reconfiguration support via the reconfig() call. We 
> should, at the very least, ensure that only the Admin can reconfigure a 
> cluster. Perhaps restricting access to /zookeeper/config as well, though this 
> is debatable. Surely one could ensure Admin only access via an ACL, but that 
> would leave everyone who doesn't use ACLs unprotected. We could also force a 
> default ACL to make it a bit more consistent (maybe).
> Finally, making reconfig() only available to Admins means they have to run 
> with zookeeper.DigestAuthenticationProvider.superDigest (which I am not sure 
> if everyone does, or how would it work with other authentication providers). 
> Review board https://reviews.apache.org/r/51546/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to