Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r86691054
--- Diff:
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -842,7 +868,26 @@ private void addCnxn(NIOServerCnxn cnxn) {
protected NIOServerCnxn createConnection(SocketChannel sock,
SelectionKey sk, SelectorThread selectorThread) throws
IOException {
- return new NIOServerCnxn(zkServer, sock, sk, this, selectorThread);
+
+ NIOServerCnxn cnxn = null;
+
+ if (serverCnxnClassCtr != null) {
--- End diff --
nothing is wrong with it per say - just overhead, as we will call
"newInstance" on the constructor for every code path - test or not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
