[
https://issues.apache.org/jira/browse/ZOOKEEPER-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646021#comment-15646021
]
ASF GitHub Bot commented on ZOOKEEPER-2628:
-------------------------------------------
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/102#discussion_r86903124
--- Diff: src/java/main/org/apache/zookeeper/version/util/VerGen.java ---
@@ -93,6 +93,14 @@ public static void generateFile(File outputDir, Version
version, int rev, String
} catch (IOException e) {
System.out.println("Unable to generate version.Info file: "
+ e.getMessage());
+ if (w != null) {
--- End diff --
wow this is a weird one... we have it in the finally... try with resources
would make this a bit nicer too...
> Investigate and fix findbug warnings
> ------------------------------------
>
> Key: ZOOKEEPER-2628
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2628
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.5.2
> Reporter: Michael Han
> Fix For: 3.5.3
>
>
> Findbug tool used by Jenkins bot is upgraded to 3.0.1 from 2.0.3 according to
> Infra team, and this leads to 20 new warnings produced by findbug. The
> warning reports can be found on [pre commit
> builds|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/] with build
> number >= 3513. These warnings need to be triaged and fixed if they are
> legitimate.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
