[
https://issues.apache.org/jira/browse/ZOOKEEPER-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15660263#comment-15660263
]
ASF GitHub Bot commented on ZOOKEEPER-2625:
-------------------------------------------
GitHub user ArneBachmann opened a pull request:
https://github.com/apache/zookeeper/pull/105
Fix ZOOKEEPER-2625: Introduce explicit end-of-line setting for shell scripts
I added a .gitattributes file into the bin/ folder with the startup scripts.
It seems the official build servers build the ZK packages on a Windows
machine (?), because even the Bash Shell scripts have CRLF line endings
(extracted from the downloaded archive, not from a git checkout), which caused
bug ZK-2625, as reported by me.
Since I don't have a build server myself and would build under Linux, I
cannot check if this PR fixes the bug, please advise.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ArneBachmann/zookeeper master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/105.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #105
----
commit 6b58447a5da859736cb019ff1c4e41d9dcb5bbe1
Author: Arne Bachmann <[email protected]>
Date: 2016-11-12T20:32:27Z
Introduce explicit end-of-line setting for shell scripts.
----
> zkServer.sh creates PID file in the folder data?/ instead of data/
> ------------------------------------------------------------------
>
> Key: ZOOKEEPER-2625
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2625
> Project: ZooKeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.5.2
> Environment: Linux vagrant-ubuntu-trusty-32 3.13.0-100-generic
> #147-Ubuntu SMP Tue Oct 18 16:49:53 UTC 2016 i686 i686 i686 GNU/Linux
> Reporter: Arne Bachmann
> Priority: Minor
> Labels: build
>
> I provision a vagrant vm that installs zookeeper into /home/vagrant/zk and
> adjusts all owner and read/write rights.
> With the vagrant user, I start zookeeper as bin/zkServer.sh start
> /vagrant/data/zoo.cfg
> However, the folder data? (or data^M) gets created with the PID inside,
> instead of putting it into the data folder, which contains the version-2
> folder.
> Since I'm using the official start scripts, I'm at a loss.
> Also, the data? folder comes with root:root ownership, which is strange, as
> zKServer.sh is executed from the vagrant user.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
