Github user hanm commented on a diff in the pull request:
    --- Diff: 
src/java/test/org/apache/zookeeper/test/ ---
    @@ -0,0 +1,134 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.zookeeper.test;
    +import java.util.List;
    +import java.util.LinkedList;
    +import org.apache.log4j.Logger;
    +import org.apache.zookeeper.CreateMode;
    +import org.apache.zookeeper.PortAssignment;
    +import org.apache.zookeeper.WatchedEvent;
    +import org.apache.zookeeper.Watcher;
    +import org.apache.zookeeper.ZKTestCase;
    +import org.apache.zookeeper.ZooKeeper;
    +import org.apache.zookeeper.ZooDefs.Ids;
    +import org.apache.zookeeper.server.quorum.Leader.Proposal;
    +import org.apache.zookeeper.server.ServerCnxnFactory;
    +import org.apache.zookeeper.server.SyncRequestProcessor;
    +import org.apache.zookeeper.server.ZooKeeperServer;
    +import org.apache.zookeeper.server.persistence.FileTxnSnapLog;
    +import org.junit.Assert;
    +import org.junit.Test;
    +/** If snapshots are corrupted to the empty file or deleted, Zookeeper 
    + *  not proceed to read its transactiong log files
    + *  Test that zxid == -1 in the presence of emptied/deleted snapshots
    + */
    +public class EmptiedSnapshotRecoveryTest extends ZKTestCase implements  
Watcher {
    +    private static final Logger LOG = 
    +    private static String HOSTPORT = "" + 
    +    private static final int CONNECTION_TIMEOUT = 3000;
    +    private static final int N_TRANSACTIONS = 150;
    +    private static final int SNAP_COUNT = 100;
    +    public void runTest(boolean leaveEmptyFile) throws Exception {
    --- End diff --
    Test coverage improvement suggestion: here we don't cover the case where 
both transaction log files and snap shot files are missing (either deleted, or 
empty) - in which case the ZK server should happily recover w/o problem. 
Something like this should work: `runTest(boolean leaveEmptySnapshotFile, 
boolean leaveEmptyTxnLogFile)`.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to