Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r90942133
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -71,7 +71,7 @@
NettyServerCnxnFactory factory;
boolean initialized;
- NettyServerCnxn(Channel channel, ZooKeeperServer zks,
NettyServerCnxnFactory factory) {
+ public NettyServerCnxn(Channel channel, ZooKeeperServer zks,
NettyServerCnxnFactory factory) {
--- End diff --
@yufeldman Yeah the tests are fine. What I mentioned that leads to
`NettyServerCnxnx` not get instantiated only happens in erroneous cases when
`ZOOKEEPER_SERVER_CNXN_FACTORY` is not initialized properly - this happens when
the public specifier was removed so all tests fall back to create
`NIOServerCnxnx` instead. That's not a real alarm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
