Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92298117
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -694,7 +690,7 @@ public void sendResponse(ReplyHeader h, Record r,
String tag) {
}
}
} catch(Exception e) {
- LOG.warn("Unexpected exception. Destruction averted.", e);
+ throw new IOException(e);
--- End diff --
Just a suggestion: wdyt about bubbling up a more custom message with the
IOException instead of just encapsulate the Exception? I mean, something like:
``
throw new IOException("sendMessage exception: blah blah", e);
``
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
