Github user mikaelstaldal commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/148#discussion_r96145959
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -413,13 +418,18 @@ public void testBadPeerAddressInQuorum() throws
Exception {
ClientBase.setupTestEnv();
// setup the logger to capture all logs
+ LoggerContext loggerContext = (LoggerContext)
LogManager.getContext(false);
+ Configuration logConfig = loggerContext.getConfiguration();
+
Layout layout =
- Logger.getRootLogger().getAppender("CONSOLE").getLayout();
+
logConfig.getRootLogger().getAppenders().get("STDOUT").getLayout();
+ String appenderName = "quorumAppender";
ByteArrayOutputStream os = new ByteArrayOutputStream();
- WriterAppender appender = new WriterAppender(layout, os);
- appender.setThreshold(Level.WARN);
- Logger qlogger =
Logger.getLogger("org.apache.zookeeper.server.quorum");
- qlogger.addAppender(appender);
+ WriterAppender appender =
WriterAppender.createAppender((StringLayout)layout, null, new
OutputStreamWriter(os), appenderName, false, true);
--- End diff --
It's probably a good idea to use the builder to create the appender:
```
WriterAppender.newBuilder().setLayout((StringLayout)layout).setTarget(new
OutputStreamWriter(os)).setName(appenderName).build();
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
