Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/150#discussion_r96170084
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -87,15 +73,69 @@ public StaticHostProvider(Collection<InetSocketAddress>
serverAddresses)
Collections.shuffle(this.serverAddresses);
}
+ /**
+ * In Java 7, we have a method getHostString, but earlier versions do
not support it.
+ * This method is to provide a replacement for
InetSocketAddress.getHostString().
+ *
+ * It evaluates to a hostname if one is available and otherwise it
returns the
+ * string representation of the IP address.
+ *
+ * @param addr
+ * @return Hostname string of address parameter
+ */
+ private String getHostString(InetSocketAddress addr) {
--- End diff --
Java 6 has getHostString, but it's package private. Use reflection can
access that. Maybe we should use the library version instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
