[
https://issues.apache.org/jira/browse/ZOOKEEPER-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823939#comment-15823939
]
ASF GitHub Bot commented on ZOOKEEPER-2573:
-------------------------------------------
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/137#discussion_r96225530
--- Diff: src/lastRevision.sh ---
@@ -16,6 +16,6 @@
# Find the current revision, store it in a file
FILE=$1
-LASTREV=`svn info | grep '^Revision' | sed -e 's/Revision: *//'`
+LASTREV=`git rev-parse HEAD | cut -c1-8`
--- End diff --
Hi @rakeskadr, usually the first 8 characters of commit are enough to
identify the commit.
But I think putting the whole SHA-1 is nice, because the more context the
better. Also, it simplifies the code even more (to substr the sha1 is annoying
on windows).
Thanks for pointing out!
> Modify Info.REVISION to adapt git repo
> --------------------------------------
>
> Key: ZOOKEEPER-2573
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2573
> Project: ZooKeeper
> Issue Type: Bug
> Components: build, server
> Affects Versions: 3.4.9, 3.5.2
> Reporter: Arshad Mohammad
> Assignee: Edward Ribeiro
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> Modify {{org.apache.zookeeper.version.Info.REVISION}} to store git repo
> revision
> Currently {{org.apache.zookeeper.version.Info.REVISION}} stores the svn repo
> revision which is of type int
> But after migrating to git repo the git repo's revision(commit
> 63f5132716c08b3d8f18993bf98eb46eb42f80fb) can not be stored in this variable.
> So either we should modify this variable to string to introduce new variable
> to store the git revision and leave the svn revision variable unchanged.
> build.xml, and org.apache.zookeeper.version.util.VerGen also need to be
> modified.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
