[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866975#comment-15866975
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2696:
-------------------------------------------

GitHub user afine opened a pull request:

    https://github.com/apache/zookeeper/pull/178

    ZOOKEEPER-2696: Eclipse ant ask no longer determines correct classpath for 
tests after ZOOKEEPER-2689

    After pulling branch-3.4 i noticed that I could no longer compile and run 
the tests within my IDE. 
    
    The .classpath file generated by the eclipse ant task was missing necessary 
dependencies. These missing dependencies all appear to be transitive from 
dependencies brought in by ZOOKEEPER-2689 (which is why ant is able to run the 
tests). There were two possible ways to fix this, this patch explicitly lists 
the new transitive dependencies that are required by our test code. Another 
solution would be to remove `transitive="false"` from `<ivy:cachepath 
pathid="junit.path.id" conf="test" transitive="false"/>` in the eclipse target 
of our `build.xml`. This solution would introduce even more transitive 
dependencies to the .classpath.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/afine/zookeeper ZOOKEEPER-2696

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #178
    
----
commit bc8d6c35594f24fbb7ebf13066a746f5b7246cd1
Author: Abraham Fine <abef...@cloudera.com>
Date:   2017-02-15T00:03:35Z

    ZOOKEEPER-2696: Eclipse ant ask no longer determines correct classpath 
after ZOOKEEPER-2689

----


> Eclipse ant ask no longer determines correct classpath for tests after 
> ZOOKEEPER-2689
> -------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2696
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2696
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.10
>            Reporter: Abraham Fine
>            Assignee: Abraham Fine
>
> Following the changes made in ZOOKEEPER-2689 IDE's using the .classpath file 
> generated by the eclipse ant task (I tested both idea and eclipse) cannot 
> compile the tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to