[ https://issues.apache.org/jira/browse/ZOOKEEPER-2700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876134#comment-15876134 ]
ASF GitHub Bot commented on ZOOKEEPER-2700: ------------------------------------------- Github user revans2 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/180#discussion_r102222749 --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java --- @@ -303,15 +305,38 @@ public void loadData() throws IOException, InterruptedException { public void takeSnapshot(){ try { + lastSnapshotZxid = zkDb.getDataTreeLastProcessedZxid(); + isGeneratingSnapshot.incrementAndGet(); + txnLogFactory.save(zkDb.getDataTree(), zkDb.getSessionWithTimeOuts()); } catch (IOException e) { LOG.error("Severe unrecoverable error, exiting", e); // This is a severe error that we cannot recover from, // so we need to exit System.exit(10); + } finally { + isGeneratingSnapshot.decrementAndGet(); } } + public boolean maybeTakeSnapshot() { --- End diff -- Could you add some javadocs here? It would be nice to explain the difference between takeSnapshot and maybeTakeSnapshot. > Force ZooKeeper to generate snapshot > ------------------------------------ > > Key: ZOOKEEPER-2700 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2700 > Project: ZooKeeper > Issue Type: Improvement > Reporter: Flier Lu > Priority: Minor > > When cold backup or remote offline sync Zookeeper instances, we need the > latest snapshot. > Add a four letter `snap` command to force Zookeeper to generate snapshot. -- This message was sent by Atlassian JIRA (v6.3.15#6346)