Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r103139365
--- Diff:
src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
@@ -216,6 +216,10 @@ public static boolean isEnabled(String command) {
whiteListedCommands.add(cmd.trim());
}
}
+ // It is sad that isro and srvr are used by ZooKeeper itself.
Need fix this
+ // before deprecating 4lw.
+ whiteListedCommands.add("isro");
--- End diff --
I've few comments, please see:
comment-1) I agree that these commands are very much needed for ZK
functionality and cannot be disabled. I hope you have coded with that point in
mind. In general, default values can be overridden, but here these are
mandatory values. Can we document conveying these thoughts. Presently the
documentation says that `"The default value is empty, which disables all Four
Letter Words command."`
comment-2) Say, user keeps `4lw.commands.whitelist=<empty>`, then
`System.getProperty(ZOOKEEPER_4LW_COMMANDS_WHITELIST)` will be null and these
two commands will not be added to `whiteListedCommands`, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
