[ https://issues.apache.org/jira/browse/ZOOKEEPER-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888631#comment-15888631 ]
ASF GitHub Bot commented on ZOOKEEPER-2693: ------------------------------------------- Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/179#discussion_r103512572 --- Diff: src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java --- @@ -216,6 +216,10 @@ public static boolean isEnabled(String command) { whiteListedCommands.add(cmd.trim()); } } + // It is sad that isro and srvr are used by ZooKeeper itself. Need fix this + // before deprecating 4lw. + whiteListedCommands.add("isro"); --- End diff -- @rakeshadr thanks for feedback, updated patch. I also did an optimization that only conditionally enables "isro" only when read only mode is enabled (readonly mode is disabled by default.) with a test case, so we don't have to say that "isro" is also enabled by default in doc (the less implementation details we mention there the better imo.). > DOS attack on wchp/wchc four letter words (4lw) > ----------------------------------------------- > > Key: ZOOKEEPER-2693 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2693 > Project: ZooKeeper > Issue Type: Bug > Components: security, server > Affects Versions: 3.4.0, 3.5.1, 3.5.2 > Reporter: Patrick Hunt > Assignee: Michael Han > Priority: Blocker > Fix For: 3.4.10, 3.5.3 > > Attachments: ZOOKEEPER-2693-01.patch > > > The wchp/wchc four letter words can be exploited in a DOS attack on the ZK > client port - typically 2181. The following POC attack was recently published > on the web: > https://webcache.googleusercontent.com/search?q=cache:_CNGIz10PRYJ:https://www.exploit-db.com/exploits/41277/+&cd=14&hl=en&ct=clnk&gl=us > The most straightforward way to block this attack is to not allow access to > the client port to non-trusted clients - i.e. firewall the ZooKeeper service > and only allow access to trusted applications using it for coordination. -- This message was sent by Atlassian JIRA (v6.3.15#6346)