[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927049#comment-15927049
 ] 

Hadoop QA commented on ZOOKEEPER-2724:
--------------------------------------

+1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/420//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/420//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/420//console

This message is automatically generated.

> Skip cert files for releaseaudit target.
> ----------------------------------------
>
>                 Key: ZOOKEEPER-2724
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2724
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.5.2
>            Reporter: Michael Han
>            Assignee: Michael Han
>            Priority: Blocker
>              Labels: build
>             Fix For: 3.5.3
>
>
> In branch-3.5 release auditing generating warnings against cert files as 
> these files don't contain Apache License (AL) header. I don't think these 
> files should be checked because they are not source files, and we skip them 
> in master branch. We should do the same for branch-3.5 by skipping these cert 
> files as well. This should be fixed before 3.5.3 release.
> Attach the snippet of warning for reference:
> {noformat}
> [rat:report]  !????? 
> /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build/zookeeper-3.5.3-alpha-SNAPSHOT/contrib/rest/conf/keys/rest.cer
> [rat:report]  !????? 
> /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build/zookeeper-3.5.3-alpha-SNAPSHOT/src/contrib/rest/conf/keys/rest.cer
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to