[
https://issues.apache.org/jira/browse/ZOOKEEPER-2736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15939596#comment-15939596
]
ASF GitHub Bot commented on ZOOKEEPER-2736:
-------------------------------------------
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/205#discussion_r107824726
--- Diff:
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -794,8 +825,9 @@ public boolean removeCnxn(NIOServerCnxn cnxn) {
InetAddress addr = cnxn.getSocketAddress();
if (addr != null) {
- Set<NIOServerCnxn> set = ipMap.get(addr);
- if (set != null) {
+ IpCnxns ipCnxns = ipMap.get(addr);
+ if (ipCnxns != null) {
+ Set<NIOServerCnxn> set = ipCnxns.cnxnSet;
--- End diff --
Direct field access... I see ipCnxns is internal... But awkward yet. :smile:
> Add a connection rate limiter
> -----------------------------
>
> Key: ZOOKEEPER-2736
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2736
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.9, 3.5.2
> Reporter: Vincent Poon
> Attachments: ZOOKEEPER-2736.v1.patch
>
>
> Currently the maxClientCnxns property only limits the aggregate number of
> connections from a client, but not the rate at which connections can be
> created.
> This patch adds a configurable connection rate limiter which limits the rate
> as well.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
