Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/208#discussion_r108229036
--- Diff:
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -109,6 +110,20 @@ public void channelConnected(ChannelHandlerContext ctx,
zkServer, NettyServerCnxnFactory.this);
ctx.setAttachment(cnxn);
+ InetAddress addr =
((InetSocketAddress)cnxn.channel.getRemoteAddress()).getAddress();
+ Set<NettyServerCnxn> s = ipMap.get(addr);
--- End diff --
Not sure if this is an issue or not, but if multiple connections (from a
new address) hit this line before reaching the next one, the maxclientcnxns
will never be checked as factory.ipMap.get(address) will return null for all of
the connections?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
