Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/208#discussion_r108258656
--- Diff:
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -109,6 +110,20 @@ public void channelConnected(ChannelHandlerContext ctx,
zkServer, NettyServerCnxnFactory.this);
ctx.setAttachment(cnxn);
+ InetAddress addr =
((InetSocketAddress)cnxn.channel.getRemoteAddress()).getAddress();
+ Set<NettyServerCnxn> s = ipMap.get(addr);
--- End diff --
So I can't imagine this causing much more than the occasional extra single
connection, but I do think it is worth fixing.
My feeling here is that if we move the ipMap logic to the factory this
should be easier to fix as synchronization in a singleton is much simpler than
trying to figure out what Netty does with these CnxnChannelHandler objects.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
