Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/211#discussion_r110702056
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -87,6 +87,12 @@ public void close() {
LOG.debug("close called for sessionid:0x"
+ Long.toHexString(sessionId));
}
+
+ // ZOOKEEPER-2743:
+ // Always unregister connection upon close to prevent
+ // connection bean leak under certain race conditions.
+ factory.unregisterConnection(this);
--- End diff --
Agreed Michael. I've noticed `NIOServerCnxnFactory#removeCnxn()` execution
path, we should correct this part as well, like you mentioned in the PR
comment. Could you please raise a new jira to track the changes.
+1 the netty code changes looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
