[
https://issues.apache.org/jira/browse/ZOOKEEPER-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975208#comment-15975208
]
Brandon Berg edited comment on ZOOKEEPER-2763 at 4/19/17 6:14 PM:
------------------------------------------------------------------
[~weitang]: Note that the "& 0xff" in the fix I suggested handles the negative
case by masking off any bits outside of the least significant byte. There's no
need to check for hex.length() > 2, because Integer.toHexString(barr[idx] &
0xff) will never return a string longer than two characters.
I don't actually know anything about the process for submitting fixes;
submitting this bug report is the only interaction I've ever had with the
project so far.
was (Author: bberg):
[~weitang]: Note that the "& 0xff" in the fix I suggested handles the negative
case by masking off any bits outside of the least significant byte. There's no
need to check for hex.length() > 2, because Integer.toHexString(barr[idx] &
0xff) will never return a string longer than two characters.
> Utils.toCsvBuffer() omits leading 0 for bytes < 0x10
> ----------------------------------------------------
>
> Key: ZOOKEEPER-2763
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2763
> Project: ZooKeeper
> Issue Type: Bug
> Components: jute
> Affects Versions: 3.5.2
> Reporter: Brandon Berg
> Assignee: Alburt Hoffman
> Priority: Minor
>
> org.apache.jute.Utils.toCsvBuffer(), which converts a byte array to a string
> containing the hex representation of that byte array, omits the leading zero
> for any byte less than 0x10, due to its use of Integer.toHexString, which has
> the same behavior.
> https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/jute/Utils.java#L234
> One consequence of this is that the hex strings printed by
> ClientCnxn.Packet.toString(), used in the debug logging for
> ClientCnxn.readResponse(), cannot be parsed to determine the result of a
> Zookeeper request from client debug logs.
> Utils.toXmlBuffer() appears to have the same issue.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
