[
https://issues.apache.org/jira/browse/ZOOKEEPER-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987072#comment-15987072
]
ASF GitHub Bot commented on ZOOKEEPER-2697:
-------------------------------------------
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/222
Since we have this new close method we probably should remove the
testableClose but it looks like there are also other testable* methods since
3.3.0 and we have to consider there are many folks already use this testable
method (even not just in test code.). So it sounds good to me to keep the
testable method as is and because of this it also sounds good to me to add the
new close method to 3.5.
I think what's remaining is some doc work:
* Add @since tag in the new close method.
* Would be good to some comments in the existing close() method mentioning
that it does not release all threads internally used, and then link to the new
close method added in this patch if users want certain behavior.
> Handle graceful stop of ZookKeeper client
> -----------------------------------------
>
> Key: ZOOKEEPER-2697
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2697
> Project: ZooKeeper
> Issue Type: Improvement
> Components: java client
> Affects Versions: 3.4.9
> Reporter: Enrico Olivelli
> Priority: Critical
>
> As seen in ZOOKEEPER-1394 I would like to have the "close" which waits for
> all background activities to finish.
> In tests the method "testableWaitForShutdown" is used.
> We can add a new ZooKeeper.close(int tineout) method which will act as
> testableWaitForShutdown, joining all support threads.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
