[ https://issues.apache.org/jira/browse/ZOOKEEPER-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988442#comment-15988442 ]
Hadoop QA commented on ZOOKEEPER-2763: -------------------------------------- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/657//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/657//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/657//console This message is automatically generated. > Utils.toCsvBuffer() omits leading 0 for bytes < 0x10 > ---------------------------------------------------- > > Key: ZOOKEEPER-2763 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2763 > Project: ZooKeeper > Issue Type: Bug > Components: jute > Affects Versions: 3.5.2 > Reporter: Brandon Berg > Assignee: Alburt Hoffman > Priority: Minor > > org.apache.jute.Utils.toCsvBuffer(), which converts a byte array to a string > containing the hex representation of that byte array, omits the leading zero > for any byte less than 0x10, due to its use of Integer.toHexString, which has > the same behavior. > https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/jute/Utils.java#L234 > One consequence of this is that the hex strings printed by > ClientCnxn.Packet.toString(), used in the debug logging for > ClientCnxn.readResponse(), cannot be parsed to determine the result of a > Zookeeper request from client debug logs. > Utils.toXmlBuffer() appears to have the same issue. > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)