[
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988638#comment-15988638
]
ASF GitHub Bot commented on ZOOKEEPER-2662:
-------------------------------------------
GitHub user eribeiro opened a pull request:
https://github.com/apache/zookeeper/pull/243
ZOOKEEPER-2662: Export a metric for txn log sync times
Addressed review comments
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eribeiro/zookeeper ZOOKEEPER-2662-branch-3.5
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/243.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #243
----
commit cfd12f86b0a244b6bd697af35e2b6d03c20e31fd
Author: Edward Ribeiro <edward.ribe...@gmail.com>
Date: 2017-04-27T00:21:18Z
ZOOKEEPER-2662: Export a metric for txn log sync times
Addressed review comments
----
> Export a metric for txn log sync times
> --------------------------------------
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync
> the txn log in order to warn if that time exceeds a configurable threshold.
> This information should also be exported as a metric available by JMX so an
> important aspect of quorum performance can be monitored.
> ZooKeeperServerMXBean carries some global latency information for the server
> process already, seems like a good place to put it if not an entirely new
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same
> information for snapshots.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
