[
https://issues.apache.org/jira/browse/ZOOKEEPER-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991194#comment-15991194
]
ASF GitHub Bot commented on ZOOKEEPER-236:
------------------------------------------
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r114166007
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
@@ -254,6 +260,9 @@ protected void connectToLeader(InetSocketAddress addr)
}
sockConnect(sock, addr, Math.min(self.tickTime *
self.syncLimit, remainingInitLimitTime));
+ if (self.isSslQuorum()) {
+ ((SSLSocket) sock).startHandshake();
+ }
sock.setTcpNoDelay(nodelay);
break;
} catch (IOException e) {
--- End diff --
Is it possible to get a more typed exception here (like SSLException) when
hand shake failed? This serves several purposes: if we know the SSL cert is
invalid there is no point retrying; from supportability point of view when hand
shake failed, it's possible that what finally gets logged does not reflect the
cause of the failure due to how these exceptions are handled (for example we
may see in log that initLimit was exceeded while the real culprit is invalid
cert).
> SSL Support for Atomic Broadcast protocol
> -----------------------------------------
>
> Key: ZOOKEEPER-236
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-236
> Project: ZooKeeper
> Issue Type: New Feature
> Components: quorum, security, server
> Reporter: Benjamin Reed
> Assignee: Abraham Fine
> Labels: ssl
>
> We should have the ability to use SSL to authenticate and encrypt the traffic
> between ZooKeeper servers. For the most part this is a very easy change. We
> would probably only want to support this for TCP based leader elections.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
