Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/253
  
    Patch lgtm, almost there!
    
    There is one test failure in pre-commit build (see 'All checks have failed' 
- Details)
    
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/698/testReport/
    org.apache.zookeeper.test.ReadOnlyModeTest.testConnectionEvents
    This test was not failing without this patch, and (consistently) failing 
with the patch on Apache Jenkins. Please investigate. Generally we'd like have 
a green pre-commit build before merging a PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to