[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015156#comment-16015156 ]
ASF GitHub Bot commented on ZOOKEEPER-2784: ------------------------------------------- GitHub user asdf2014 opened a pull request: https://github.com/apache/zookeeper/pull/257 ZOOKEEPER-2784: Add same `sid` config problem check Add some limitations on code level for `SID` to avoid configuration problem You can merge this pull request into a Git repository by running: $ git pull https://github.com/asdf2014/zookeeper quorum_sid Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/257.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #257 ---- commit 4447631b3d2b7cd58f0fd4d92923ff87482330a9 Author: asdf2014 <1571805...@qq.com> Date: 2017-05-18T03:47:00Z ZOOKEEPER-2784: Add same `sid` config problem check ---- > Add some limitations on code level for `SID` to avoid configuration problem > --------------------------------------------------------------------------- > > Key: ZOOKEEPER-2784 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2784 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum > Affects Versions: 3.5.2 > Reporter: Benedict Jin > Fix For: 3.5.4 > > Original Estimate: 168h > Remaining Estimate: 168h > > As so far, `QuorumCnxManager#receiveConnection` cannot find out the same > `SID` problem, then the Zookeeper cluster will start successfully. But the > cluster is not health, and it will throw some problem like `not > synchronized`. So, i thought we should add some limitations on code level for > `SID` to find those configuration problem more early. -- This message was sent by Atlassian JIRA (v6.3.15#6346)