Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/236#discussion_r117280664
--- Diff: src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java ---
@@ -133,11 +133,17 @@ public boolean accept(File f){
}
}
// add all non-excluded log files
- List<File> files = new ArrayList<File>(Arrays.asList(txnLog
- .getDataDir().listFiles(new MyFileFilter(PREFIX_LOG))));
+ List<File> files = new ArrayList<File>();
+ File[] fileArray;
+ if ((fileArray = txnLog.getDataDir().listFiles(new
MyFileFilter(PREFIX_LOG))) != null) {
--- End diff --
Can we keep the var assignment `File[] fileArray` outside along with the
object reference instead of clubbing with if check.
File[] fileArray = txnLog.getDataDir().listFiles(new
MyFileFilter(PREFIX_LOG);
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
