Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/232#discussion_r117358635
--- Diff: src/java/main/org/apache/jute/compiler/JType.java ---
@@ -27,7 +27,7 @@
private String mCName;
private String mCppName;
private String mCsharpName;
- private String mJavaName;
+ protected String mJavaName;
--- End diff --
@rakeshadr Apologies, I must not have been clear. There are no changes here
that are for the "sake" of performance. In fact, my concern is that my changes
will negatively impact performance.
After revisiting this change I think it makes more sense for us just to
ignore the EI and EI2 issues. I reverted the changes to the jute compiler and
added org.apache.zookeeper.server.quorum.QuorumAuthPacket to the findbugs
exclusions file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
