[
https://issues.apache.org/jira/browse/ZOOKEEPER-2786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017867#comment-16017867
]
ASF GitHub Bot commented on ZOOKEEPER-2786:
-------------------------------------------
GitHub user afine opened a pull request:
https://github.com/apache/zookeeper/pull/259
ZOOKEEPER-2786: Flaky test:
org.apache.zookeeper.test.ClientTest.testNonExistingOpCode
On branch 3.5, testNonExistingOpCode appears to always take 30 seconds to
execute (far too long):
https://builds.apache.org/job/ZooKeeper_branch35_jdk7/967/testReport/org.apache.zookeeper.test/ClientTest/testNonExistingOpCode/history/
The reason for this is a call to
`zk.testableWaitForShutdown(CONNECTION_TIMEOUT)` while waiting for the client
to disconnect after it sent a request with a bad opcode to the server. The call
to `testableWaitForShutdown` never actually asserts anything and effectively
just hangs for CONNECTION_TIMEOUT (30 seconds) and returns because the client
reconnects to the server.
This patch replaces `zk.testableWaitForShutdown(CONNECTION_TIMEOUT)` with
`watcher.waitForDisconnected(5000)` which is a better way to detect if we have
been disconnected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afine/zookeeper ZOOKEEPER-2786_br3.5
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/259.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #259
----
----
> Flaky test: org.apache.zookeeper.test.ClientTest.testNonExistingOpCode
> ----------------------------------------------------------------------
>
> Key: ZOOKEEPER-2786
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2786
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.10, 3.5.3
> Reporter: Abraham Fine
> Assignee: Abraham Fine
>
> This test is broken on 3.4 and 3.5, but is broken in "different" ways. Please
> see the individual pull requests for detailed descriptions for the issues
> faced in both branches.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
