[
https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018003#comment-16018003
]
ASF GitHub Bot commented on ZOOKEEPER-2784:
-------------------------------------------
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117574653
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -371,6 +372,10 @@ public void receiveConnection(Socket sock) {
connectOne(sid);
}
+ }else if (sid == self.getId()) {
+ closeSocket(sock);
+ throw new ConfigException(String.format("Appearing duplicate
SID: %s", sid));
--- End diff --
I think this message could be more descriptive or reshaped. English is not
my 1st language, but what about _"Inconsistent ensemble setup: duplicate SID %s
found"?_
> Add some limitations on code level for `SID` to avoid configuration problem
> ---------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2784
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2784
> Project: ZooKeeper
> Issue Type: Improvement
> Components: quorum
> Affects Versions: 3.5.2
> Reporter: Benedict Jin
> Fix For: 3.6.0
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> As so far, `QuorumCnxManager#receiveConnection` cannot find out the same
> `SID` problem, then the Zookeeper cluster will start successfully. But the
> cluster is not health, and it will throw some problem like `not
> synchronized`. So, i thought we should add some limitations on code level for
> `SID` to find those configuration problem more early.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
