[
https://issues.apache.org/jira/browse/ZOOKEEPER-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020236#comment-16020236
]
ASF GitHub Bot commented on ZOOKEEPER-2762:
-------------------------------------------
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/239#discussion_r117851157
--- Diff: src/java/test/config/findbugsExcludeFile.xml ---
@@ -90,6 +90,16 @@
<Bug code="IS"/>
</Match>
<Match>
+ <Class name="org.apache.zookeeper.server.quorum.Leader"/>
+ <Method name="lead"/>
--- End diff --
@rakeshadr Initially I avoided this change because I did not want to dirty
up the diff and we were doing the correct things to prevent a race condition
with these variables. I should have checked 3.5 to see what we were doing
there. I made the change to `QuorumPeer.tick` and
`FastLeaderElection.logicalclock` but I did not make the change to
`AuthFastLeaderElection.logicalclock` because I thought it would be best to
avoid changing a deprecated class. Let me know if that's ok.
> Multithreaded correctness Warnings
> ----------------------------------
>
> Key: ZOOKEEPER-2762
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2762
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Abraham Fine
> Assignee: Abraham Fine
> Fix For: 3.4.11
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
