Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/239#discussion_r117851157
--- Diff: src/java/test/config/findbugsExcludeFile.xml ---
@@ -90,6 +90,16 @@
<Bug code="IS"/>
</Match>
<Match>
+ <Class name="org.apache.zookeeper.server.quorum.Leader"/>
+ <Method name="lead"/>
--- End diff --
@rakeshadr Initially I avoided this change because I did not want to dirty
up the diff and we were doing the correct things to prevent a race condition
with these variables. I should have checked 3.5 to see what we were doing
there. I made the change to `QuorumPeer.tick` and
`FastLeaderElection.logicalclock` but I did not make the change to
`AuthFastLeaderElection.logicalclock` because I thought it would be best to
avoid changing a deprecated class. Let me know if that's ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
