Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/240
Agree with what you said, Abe, in a generic context : ) - for CLI use cases
though I am wondering why we should crash even in cases as you mentioned "So if
it does pop up for reasons other than a bad path" - in such case should we
always print the error message and not crashing the CLI? Would that be more
helpful for user experience comparing to crash and leave no ideas to users what
went wrong? Basically my point is that I don't any use case where the CLI's
state is so bad that it can't recover from an unchecked exception so it has to
be killed.
Other than this patch looks good to me. One nit - a new compiler waring is
introduced.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
