[
https://issues.apache.org/jira/browse/ZOOKEEPER-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024515#comment-16024515
]
Janek P commented on ZOOKEEPER-2730:
------------------------------------
I have two questions:
1) my idea is to define everywhere the encoding to be 'UTF-8'. WDYT, is it the
right approach? Any issues that this might cause for consumers of the generated
files (I am thinking in particular about 'jute')
2) which version of FindBugs are you using? There is none included with the
project. I would like to have matching distribution.
> Cleanup findbug warnings in branch-3.4: Internationalization Warnings
> ---------------------------------------------------------------------
>
> Key: ZOOKEEPER-2730
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2730
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Rakesh R
> Fix For: 3.4.11
>
>
> Please refer the attached sheet in parent jira. Below is the details of
> findbug warnings.
> {code}
> Dm Found reliance on default encoding in
> org.apache.jute.compiler.CGenerator.genCode(): new java.io.FileWriter(File)
> Dm Found reliance on default encoding in
> org.apache.jute.compiler.CppGenerator.genCode(): new java.io.FileWriter(File)
> Dm Found reliance on default encoding in
> org.apache.jute.compiler.JRecord.genCsharpCode(File): new
> java.io.FileWriter(File)
> Dm Found reliance on default encoding in
> org.apache.jute.compiler.JRecord.genJavaCode(File): new
> java.io.FileWriter(File)
> Dm Found reliance on default encoding in new
> org.apache.jute.XmlOutputArchive(OutputStream): new
> java.io.PrintStream(OutputStream)
> Dm Found reliance on default encoding in
> org.apache.zookeeper.client.FourLetterWordMain.send4LetterWord(String, int,
> String, int): new java.io.InputStreamReader(InputStream)
> Dm Found reliance on default encoding in
> org.apache.zookeeper.client.FourLetterWordMain.send4LetterWord(String, int,
> String, int): String.getBytes()
> Dm Found reliance on default encoding in
> org.apache.zookeeper.ClientCnxn$SendThread.pingRwServer(): new
> java.io.InputStreamReader(InputStream)
> Dm Found reliance on default encoding in
> org.apache.zookeeper.ClientCnxn$SendThread.pingRwServer(): String.getBytes()
> Dm Found reliance on default encoding in
> org.apache.zookeeper.server.auth.DigestAuthenticationProvider.generateDigest(String):
> String.getBytes()
> Dm Found reliance on default encoding in
> org.apache.zookeeper.server.auth.DigestAuthenticationProvider.handleAuthentication(ServerCnxn,
> byte[]): new String(byte[])
> Dm Found reliance on default encoding in
> org.apache.zookeeper.server.DataTree.updateBytes(String, long): new
> String(byte[])
> Dm Found reliance on default encoding in
> org.apache.zookeeper.server.DataTree.updateBytes(String, long):
> String.getBytes()
> Dm Found reliance on default encoding in
> org.apache.zookeeper.server.DataTree.updateCount(String, int): new
> String(byte[])
> Dm Found reliance on default encoding in
> org.apache.zookeeper.server.DataTree.updateCount(String, int):
> String.getBytes()
> Dm Found reliance on default encoding in
> org.apache.zookeeper.server.DataTree.updateQuotaForPath(String):
> String.getBytes()
> Dm Found reliance on default encoding in
> org.apache.zookeeper.server.NettyServerCnxn$SendBufferWriter.checkFlush(boolean):
> String.getBytes()
> Dm Found reliance on default encoding in
> org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(boolean):
> String.getBytes()
> Dm Found reliance on default encoding in
> org.apache.zookeeper.server.persistence.FileSnap.<static initializer for
> FileSnap>(): String.getBytes()
> Dm Found reliance on default encoding in
> org.apache.zookeeper.server.persistence.FileTxnLog.<static initializer for
> FileTxnLog>(): String.getBytes()
> Dm Found reliance on default encoding in
> org.apache.zookeeper.server.quorum.QuorumPeer.readLongFromFile(String): new
> java.io.FileReader(File)
> Dm Found reliance on default encoding in
> org.apache.zookeeper.server.quorum.QuorumPeer.writeLongToFile(String, long):
> new java.io.OutputStreamWriter(OutputStream)
> Dm Found reliance on default encoding in
> org.apache.zookeeper.server.quorum.QuorumPeerConfig.parseProperties(Properties):
> new java.io.FileReader(File)
> Dm Found reliance on default encoding in
> org.apache.zookeeper.server.Request.toString(): new String(byte[])
> Dm Found reliance on default encoding in
> org.apache.zookeeper.server.ServerCnxn.<static initializer for ServerCnxn>():
> String.getBytes()
> Dm Found reliance on default encoding in
> org.apache.zookeeper.server.TraceFormatter.main(String[]): new String(byte[])
> Dm Found reliance on default encoding in
> org.apache.zookeeper.server.util.OSMXBean.getMaxFileDescriptorCount(): new
> java.io.InputStreamReader(InputStream)
> Dm Found reliance on default encoding in
> org.apache.zookeeper.server.util.OSMXBean.getOpenFileDescriptorCount(): new
> java.io.InputStreamReader(InputStream)
> Dm Found reliance on default encoding in
> org.apache.zookeeper.ServerAdminClient.dump(String, int): new String(byte[])
> Dm Found reliance on default encoding in
> org.apache.zookeeper.ServerAdminClient.dump(String, int): String.getBytes()
> Dm Found reliance on default encoding in
> org.apache.zookeeper.ServerAdminClient.getTraceMask(String, int):
> String.getBytes()
> Dm Found reliance on default encoding in
> org.apache.zookeeper.ServerAdminClient.kill(String, int): new String(byte[])
> Dm Found reliance on default encoding in
> org.apache.zookeeper.ServerAdminClient.kill(String, int): String.getBytes()
> Dm Found reliance on default encoding in
> org.apache.zookeeper.ServerAdminClient.ruok(String, int): new String(byte[])
> Dm Found reliance on default encoding in
> org.apache.zookeeper.ServerAdminClient.ruok(String, int): String.getBytes()
> Dm Found reliance on default encoding in
> org.apache.zookeeper.ServerAdminClient.setTraceMask(String, int, String):
> String.getBytes()
> Dm Found reliance on default encoding in
> org.apache.zookeeper.ServerAdminClient.stat(String, int): new String(byte[])
> Dm Found reliance on default encoding in
> org.apache.zookeeper.ServerAdminClient.stat(String, int): String.getBytes()
> Dm Found reliance on default encoding in
> org.apache.zookeeper.Shell.runCommand(): new
> java.io.InputStreamReader(InputStream)
> Dm Found reliance on default encoding in
> org.apache.zookeeper.version.util.VerGen.generateFile(File, VerGen$Version,
> String, String): new java.io.FileWriter(File)
> Dm Found reliance on default encoding in
> org.apache.zookeeper.ZooKeeperMain.createQuota(ZooKeeper, String, long, int):
> new String(byte[])
> Dm Found reliance on default encoding in
> org.apache.zookeeper.ZooKeeperMain.createQuota(ZooKeeper, String, long, int):
> String.getBytes()
> Dm Found reliance on default encoding in
> org.apache.zookeeper.ZooKeeperMain.delQuota(ZooKeeper, String, boolean,
> boolean): new String(byte[])
> Dm Found reliance on default encoding in
> org.apache.zookeeper.ZooKeeperMain.delQuota(ZooKeeper, String, boolean,
> boolean): String.getBytes()
> Dm Found reliance on default encoding in
> org.apache.zookeeper.ZooKeeperMain.processZKCmd(ZooKeeperMain$MyCommandOptions):
> new String(byte[])
> Dm Found reliance on default encoding in
> org.apache.zookeeper.ZooKeeperMain.processZKCmd(ZooKeeperMain$MyCommandOptions):
> String.getBytes()
> Dm Found reliance on default encoding in
> org.apache.zookeeper.ZooKeeperMain.run(): new
> java.io.InputStreamReader(InputStream)
> Dm Found reliance on default encoding in
> org.apache.zookeeper.ZooKeeperMain$1.processResult(int, String, Object,
> byte[], Stat): new String(byte[])
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
