[
https://issues.apache.org/jira/browse/ZOOKEEPER-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030659#comment-16030659
]
Hadoop QA commented on ZOOKEEPER-2788:
--------------------------------------
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that
doesn't require tests.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 48 new Findbugs (version
3.0.1) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/752//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/752//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/752//console
This message is automatically generated.
> The define of MAX_CONNECTION_ATTEMPTS in QuorumCnxManager.java seems useless,
> should it be removed?
> ---------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2788
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2788
> Project: ZooKeeper
> Issue Type: Improvement
> Components: leaderElection, quorum
> Affects Versions: 3.4.10, 3.5.3, 3.4.11
> Reporter: JiangJiafu
> Assignee: Abraham Fine
> Priority: Minor
>
> The define of MAX_CONNECTION_ATTEMPTS in QuorumCnxManager.java seems useless,
> should it be removed?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
