Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/274#discussion_r120239746
--- Diff: docs/zookeeperAdmin.html ---
@@ -1446,7 +1446,17 @@ <h3 class="h4">Configuration Parameters</h3>
</pre>
</dd>
-
+<dt>
+<term>tcpKeepAlive</term>
+</dt>
+<dd>
+<p>(No Java system property)</p>
--- End diff --
Updated previous comment: I haven't seen your change to QuorumPeerConfig
when commented on this. Though I think having a system property might be a more
flexible option with less changes required. I don't think we have firm standard
on which config option should have system properties and which ones should not,
so I am ok either way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
