[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059864#comment-16059864
 ] 

ASF GitHub Bot commented on ZOOKEEPER-1782:
-------------------------------------------

Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/282
  
    `zookeeper.superUser` was added in ZOOKEEPER-938 and it was never 
documented. I doubt people even know about this property without looking into 
source code and/or the description of ZOOKEEPER-938, but I agree compatibility 
concern here is very reasonable. 
    
    So let's stick to `zookeeper.superUser` for this patch. We can give it a 
shinny name later. The only remaining work is to document this 
`zookeeper.superUser`. The doc source is located 
https://github.com/apache/zookeeper/blob/master/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml,
 search `zookeeper.DigestAuthenticationProvider.superDigest` or 
`X509AuthenticationProvider.superUser` as references of existing superuser 
documents.


> zookeeper.superUser is not as super as superDigest
> --------------------------------------------------
>
>                 Key: ZOOKEEPER-1782
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1782
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.5
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>         Attachments: zk-1782.patch, zk-1782.patch
>
>
> The zookeeper.superUser system property does not fully grant super user 
> privileges, like zookeeper.DigestAuthenticationProvider.superDigest does.
> zookeeper.superUser only has as many privileges as the sasl ACLs on the znode 
> being accessed.  This means that if a znode only has digest ACLs 
> zookeeper.superUser is ignored.  Or if a znode has a single sasl ACL that 
> only has read privileges zookeeper.superUser only has read privileges.
> The reason for this is that SASLAuthenticationProvider implements the 
> superUser check in the matches method, instead of having the super user 
> include a new Id("super","") as Digest does.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to