[
https://issues.apache.org/jira/browse/ZOOKEEPER-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063959#comment-16063959
]
ASF GitHub Bot commented on ZOOKEEPER-2819:
-------------------------------------------
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/292
ZOOKEEPER-2819:Changing membership configuration via rolling restart …
…does not work on 3.5.x.
This patch disables the creation of dynamic config files (zoo.cfg.dynamic)
and static config back up files (zoo.cfg.bak) when the dynamic reconfig feature
flag (reconfigEnabled) is disabled. With this patch the membership information
(such as server list) will be stored in static zoo.cfg file and such
information would not go through quorum and leader / follower sync phase, which
makes it possible for users to continue using the old rolling restart approach.
@shralex PTAL.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hanm/zookeeper ZOOKEEPER-2819
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/292.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #292
----
commit 896ee06502d602ea5147d489a5e6f777fbaaa83e
Author: Michael Han <[email protected]>
Date: 2017-06-26T22:41:26Z
ZOOKEEPER-2819:Changing membership configuration via rolling restart does
not work on 3.5.x.
This patch disables the creation of dynamic config files (zoo.cfg.dynamic)
and static config back up files (zoo.cfg.bak) when the dynamic reconfig feature
flag (reconfigEnabled) is disabled. With this patch the membership information
(such as server list) will be stored in static zoo.cfg file and such
information would not go through quorum and leader / follower sync phase, which
makes it possible for users to continue using the old rolling restart approach.
----
> Changing membership configuration via rolling restart does not work on 3.5.x.
> -----------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2819
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2819
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum, server
> Affects Versions: 3.5.0, 3.5.1, 3.5.2, 3.5.3
> Reporter: Michael Han
> Assignee: Michael Han
> Priority: Critical
>
> In 3.5.x there is no easy way of changing the membership config using rolling
> restarts because of the introduction of dynamic reconfig feature in
> ZOOKEEPER-107, which automatically manages membership configuration
> parameters.
> ZOOKEEPER-2014 introduced a reconfigEnabled flag to turn on / off the
> reconfig feature. We can use same flag and when it sets to false, it should
> disable both in memory and on disk updates of membership configuration
> information, besides disabling the reconfig commands on CLI which
> ZOOKEEPER-2014 already did, so users can continue using rolling restarts if
> needed.
> We should also document explicitly the support of membership changes via
> rolling restarts will be deprecated at what release time frame and promote
> reconfig as the replacement.
> The problem was raised at user mailing list by Guillermo Vega-Toro, reference
> thread:
> http://zookeeper-user.578899.n2.nabble.com/How-to-add-nodes-to-a-Zookeeper-3-5-3-beta-ensemble-with-reconfigEnabled-false-td7583138.html
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
