[
https://issues.apache.org/jira/browse/ZOOKEEPER-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068921#comment-16068921
]
ASF GitHub Bot commented on ZOOKEEPER-2821:
-------------------------------------------
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/293#discussion_r124902518
--- Diff:
src/java/main/org/apache/zookeeper/server/auth/SASLAuthenticationProvider.java
---
@@ -28,24 +28,20 @@ public String getScheme() {
}
public KeeperException.Code
- handleAuthentication(ServerCnxn cnxn, byte[] authData)
- {
+ handleAuthentication(ServerCnxn cnxn, byte[] authData) {
// Should never call this: SASL authentication is negotiated at
session initiation.
// TODO: consider substituting current implementation of direct
ClientCnxn manipulation with
// a call to this method
(SASLAuthenticationProvider:handleAuthentication()) at session initiation.
return KeeperException.Code.AUTHFAILED;
}
- public boolean matches(String id,String aclExpr) {
- if ((id.equals("super") || id.equals(aclExpr))) {
--- End diff --
why was this change necessary?
> 1. Fix spell issues; 2. Remove unnecessary boxing / unboxing; 3. Simplify
> `return` clause; 4. Remove `final` qualifier from `private` method
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2821
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2821
> Project: ZooKeeper
> Issue Type: Improvement
> Components: security
> Affects Versions: 3.5.3
> Reporter: Benedict Jin
> Assignee: Benedict Jin
> Priority: Minor
> Labels: refactoring
> Fix For: 3.5.4, 3.6.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> * Fix spell issues
> * Remove unnecessary boxing / unboxing
> * Simplify `return` clause
> * Remove `final` qualifier from `private` method
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
