[ https://issues.apache.org/jira/browse/ZOOKEEPER-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070703#comment-16070703 ]
ASF GitHub Bot commented on ZOOKEEPER-2819: ------------------------------------------- Github user shralex commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/292#discussion_r125121157 --- Diff: src/java/test/org/apache/zookeeper/test/ReconfigExceptionTest.java --- @@ -89,6 +89,7 @@ public void tearDown() throws Exception { @Test(timeout = 10000) public void testReconfigDisabledByDefault() throws InterruptedException { + QuorumPeerConfig.setReconfigEnabled(false); --- End diff -- Given that the test is called "disabled-by-default" Its strange to disable this manually here. I suggest to rename the test to reflect what its doing - checking that when the flag is false reconfig ops aren't allowed. > Changing membership configuration via rolling restart does not work on 3.5.x. > ----------------------------------------------------------------------------- > > Key: ZOOKEEPER-2819 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2819 > Project: ZooKeeper > Issue Type: Bug > Components: quorum, server > Affects Versions: 3.5.0, 3.5.1, 3.5.2, 3.5.3 > Reporter: Michael Han > Assignee: Michael Han > Priority: Critical > > In 3.5.x there is no easy way of changing the membership config using rolling > restarts because of the introduction of dynamic reconfig feature in > ZOOKEEPER-107, which automatically manages membership configuration > parameters. > ZOOKEEPER-2014 introduced a reconfigEnabled flag to turn on / off the > reconfig feature. We can use same flag and when it sets to false, it should > disable both in memory and on disk updates of membership configuration > information, besides disabling the reconfig commands on CLI which > ZOOKEEPER-2014 already did, so users can continue using rolling restarts if > needed. > We should also document explicitly the support of membership changes via > rolling restarts will be deprecated at what release time frame and promote > reconfig as the replacement. > The problem was raised at user mailing list by Guillermo Vega-Toro, reference > thread: > http://zookeeper-user.578899.n2.nabble.com/How-to-add-nodes-to-a-Zookeeper-3-5-3-beta-ensemble-with-reconfigEnabled-false-td7583138.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)