[ https://issues.apache.org/jira/browse/ZOOKEEPER-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071509#comment-16071509 ]
Hadoop QA commented on ZOOKEEPER-2819: -------------------------------------- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/854//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/854//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/854//console This message is automatically generated. > Changing membership configuration via rolling restart does not work on 3.5.x. > ----------------------------------------------------------------------------- > > Key: ZOOKEEPER-2819 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2819 > Project: ZooKeeper > Issue Type: Bug > Components: quorum, server > Affects Versions: 3.5.0, 3.5.1, 3.5.2, 3.5.3 > Reporter: Michael Han > Assignee: Michael Han > Priority: Critical > > In 3.5.x there is no easy way of changing the membership config using rolling > restarts because of the introduction of dynamic reconfig feature in > ZOOKEEPER-107, which automatically manages membership configuration > parameters. > ZOOKEEPER-2014 introduced a reconfigEnabled flag to turn on / off the > reconfig feature. We can use same flag and when it sets to false, it should > disable both in memory and on disk updates of membership configuration > information, besides disabling the reconfig commands on CLI which > ZOOKEEPER-2014 already did, so users can continue using rolling restarts if > needed. > We should also document explicitly the support of membership changes via > rolling restarts will be deprecated at what release time frame and promote > reconfig as the replacement. > The problem was raised at user mailing list by Guillermo Vega-Toro, reference > thread: > http://zookeeper-user.578899.n2.nabble.com/How-to-add-nodes-to-a-Zookeeper-3-5-3-beta-ensemble-with-reconfigEnabled-false-td7583138.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)