Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/279#discussion_r126593104
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -1436,7 +1436,7 @@ public String create(final String path, byte data[],
List<ACL> acl,
request.setData(data);
request.setFlags(createMode.toFlag());
request.setPath(serverPath);
- if (acl != null && acl.size() == 0) {
+ if (acl == null || acl.isEmpty() || acl.contains(null)) {
--- End diff --
+1 on this. We can throw IllegalArgumentException instead of
KeeperException (which would change API signature) on async methods. It's good
to catch the bad arguments at client side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
