[ https://issues.apache.org/jira/browse/ZOOKEEPER-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091472#comment-16091472 ]
ASF GitHub Bot commented on ZOOKEEPER-1669: ------------------------------------------- GitHub user CheneySun opened a pull request: https://github.com/apache/zookeeper/pull/312 ZOOKEEPER-1669: Operations to server will be timed-out while thousands of sessions expired same time just porting the work in [ZOOKEEPER-1347] to branch 3.4 You can merge this pull request into a Git repository by running: $ git pull https://github.com/CheneySun/zookeeper branch-3.4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/312.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #312 ---- commit 59d71077640643f13f036dd67741ef944b48255b Author: Cheney Sun <su...@qiyi.com> Date: 2017-07-18T12:14:01Z ZOOKEEPER-1669: Operations to server will be timed-out while thousands of sessions expired same time ---- > Operations to server will be timed-out while thousands of sessions expired > same time > ------------------------------------------------------------------------------------ > > Key: ZOOKEEPER-1669 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1669 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Affects Versions: 3.3.5 > Reporter: tokoot > Assignee: Cheney Sun > Labels: performance > > If there are thousands of clients, and most of them disconnect with server > same time(client restarted or servers partitioned with clients), the server > will busy to close those "connections" and become unavailable. The problem is > in following: > private void closeSessionWithoutWakeup(long sessionId) { > HashSet<NIOServerCnxn> cnxns; > synchronized (this.cnxns) { > cnxns = (HashSet<NIOServerCnxn>)this.cnxns.clone(); // other > thread will block because of here > } > ... > } -- This message was sent by Atlassian JIRA (v6.4.14#64029)