[
https://issues.apache.org/jira/browse/ZOOKEEPER-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101183#comment-16101183
]
Michael Han commented on ZOOKEEPER-2856:
----------------------------------------
[~panyuxuan] Thanks for the patch. It's a good improvement.
Instead of uploading patch you can file a pull request instead. That is our
recommended approach for new contribution. The benefit is you will get your
github contribution credit when the patch is merged. Please refer
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute for more
details. For this case since the change is trivial I can commit your patch
directly, it's up to you.
For the patch itself, can you use parameterized logging instead?
> ZooKeeperSaslClient#respondToServer should log exception message of
> SaslException
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2856
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2856
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.4.10, 3.5.3
> Reporter: Pan Yuxuan
> Assignee: Pan Yuxuan
> Priority: Minor
> Attachments: ZOOKEEPER-2856-1.patch
>
>
> When upstream like HBase call ZooKeeperSaslClient with security enabled, we
> sometimes get error in HBase logs like:
> {noformat}
> SASL authentication failed using login context 'Client'.
> {noformat}
> This error occures when getting SaslException in
> ZooKeeperSaslClient#respondToServer :
> {noformat}
> catch (SaslException e) {
> LOG.error("SASL authentication failed using login context '" +
> this.getLoginContext() + "'.");
> saslState = SaslState.FAILED;
> gotLastPacket = true;
> }
> {noformat}
> This error makes user confused without explicit exception message. So I think
> we can add exception message to the log.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
