[
https://issues.apache.org/jira/browse/ZOOKEEPER-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103886#comment-16103886
]
ASF GitHub Bot commented on ZOOKEEPER-2829:
-------------------------------------------
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/316
Sounds good to me - my concern was that these empty packages should be
removed but since Hadoop and Hbase also has this "feature", and removing them
default the purpose of the annotation, I am OK with current approach.
I also verified the new javadoc with "ant javadoc", the newly added classes
/ APIs also look good. Overall LGTM, good work @afine. Will merge soon.
> Interface usability / compatibility improvements through Java annotation.
> -------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2829
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2829
> Project: ZooKeeper
> Issue Type: Improvement
> Components: java client, server
> Affects Versions: 3.4.10, 3.5.3
> Reporter: Michael Han
> Assignee: Abraham Fine
> Labels: annotation
>
> Hadoop has interface classification regarding the interfaces' scope and
> stability. ZK should do something similar, which not only provides additional
> benefits of making API compatibility easier between releases (or even
> commits, by automating the checks via some tooling), but also consistent with
> rest of Hadoop ecosystem.
> See HADOOP-5073 for more context.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
