Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/315#discussion_r129956031
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -1451,7 +1452,12 @@ public synchronized void
restartLeaderElection(QuorumVerifier qvOLD, QuorumVerif
}
public String getNextDynamicConfigFilename() {
- return configFilename +
QuorumPeerConfig.nextDynamicConfigFileSuffix;
+ if (configFilename != null) {
--- End diff --
Update pull request based on offline chat with Alex. The idea is to detect
the null cases for configFileName and for those cases don't write intermediate
reconfig file to disk because if we do, the shared "null.dynamic.cfg" file will
be overwritten and might likely break other things without notice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
