[
https://issues.apache.org/jira/browse/ZOOKEEPER-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112171#comment-16112171
]
ASF GitHub Bot commented on ZOOKEEPER-2852:
-------------------------------------------
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/321#discussion_r131051673
--- Diff: src/java/main/org/apache/zookeeper/server/ZKDatabase.java ---
@@ -98,6 +98,16 @@ public ZKDatabase(FileTxnSnapLog snapLog) {
dataTree = new DataTree();
sessionsWithTimeouts = new ConcurrentHashMap<Long, Integer>();
this.snapLog = snapLog;
+
+ // Read system property
+ String value = System.getProperty(SNAPSHOT_SIZE_FACTOR, "0.33");
+ try {
+ snapshotSizeFactor = Double.parseDouble(value);
+ } catch (NumberFormatException e) {
+ LOG.error("Error parsing " + SNAPSHOT_SIZE_FACTOR
--- End diff --
Please use parameterized log messages.
> Snapshot size factor is not read from system property
> -----------------------------------------------------
>
> Key: ZOOKEEPER-2852
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2852
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.5.3, 3.6.0
> Reporter: Fangmin Lv
> Assignee: Fangmin Lv
>
> There is data inconsistency issue found when leader is using on disk txn
> files to sync with learner: ZOOKEEPER-2846, tried to disable this feature by
> setting zookeeper.snapshotSizeFactor system property, but found this system
> property is not being read anywhere.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
