Hadoop QA commented on ZOOKEEPER-2861:

+1 overall.  GitHub Pull Request  Build

    +1 @author.  The patch does not contain any @author tags.

    +0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
Findbugs warnings: 
Console output: 

This message is automatically generated.

> Main-Class JAR manifest attribute is incorrect
> ----------------------------------------------
>                 Key: ZOOKEEPER-2861
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2861
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: build
>            Reporter: Yaniv Kunda
>            Priority: Minor
> ZOOKEEPER-82 (fixed since 3.0.0) had QuorumPeerMain extracted from 
> QuorumPeer, but the Main-Class attribute in the JAR manifest was not changed 
> accordingly.
> Fixing this will enable to start the server using "java -jar" instead of 
> specifying the class name.

This message was sent by Atlassian JIRA

Reply via email to